wow/reaction: State.lua comparison

comparison State.lua @ 97:5d3b7b025142

Fixed problems with stances/forms not initializing correctly

author	Flick <flickerstreak@gmail.com>
date	Thu, 23 Oct 2008 00:01:00 +0000
parents	aa9074c92f11
children	a44173c7a82c

comparison

equal deleted inserted replaced

-:aa9074c92f11
+:5d3b7b025142
 combat        = "combat",
 nocombat      = "nocombat",
 possess       = "bonusbar:5",
 }
--- Have to do these shenanigans instead of hardcoding the stances/forms because
+-- Have to do these shenanigans instead of hardcoding the stances/forms because the
--- the ordering varies if the character is missing a form. For warriors
+-- ordering varies if the character is missing a form. For warriors this is rarely
--- this is rarely a problem (c'mon, who actually skips the level 10 def stance quest?)
+-- a problem (c'mon, who actually skips the level 10 def stance quest?) but for druids
--- but for druids it can be. Some people never bother to do the aquatic form quest
+-- it can be. Some people never bother to do the aquatic form quest until well past
--- until well past when they get cat form, and stance 5/6 can be flight, tree, or moonkin
+-- when they get cat form, and stance 5/6 can be flight, tree, or moonkin depending
--- depending on talents.
+-- on talents.
 function InitRules()
 local forms = { }
 -- sort by icon since it's locale-independent
 for i = 1, GetNumShapeshiftForms() do
-local icon = GetShapeshiftFormInfo(i)
+local icon, name, active = GetShapeshiftFormInfo(i)
+-- if it's the current form, the icon is wrong (Ability_Spell_WispSplode)
+-- so capture it from the spell info directly
+if active then
+local _1, _2
+_1, _2, icon = GetSpellInfo(name)
+end
 forms[icon] = i;
 end
 -- use 9 if not found since 9 is never a valid stance/form
 local defensive = forms["Interface\\Icons\\Ability_Warrior_DefensiveStance"] or 9
 local berserker = forms["Interface\\Icons\\Ability_Racial_Avatar"] or 9
 bars = { },
 }
 }
 )
-InitRules()
+self:RegisterEvent("UPDATE_SHAPESHIFT_FORMS")
-self:RegisterEvent("PLAYER_AURAS_CHANGED")
 ReAction:RegisterBarOptionGenerator(self, "GetBarOptions")
 ReAction.RegisterCallback(self, "OnCreateBar","OnRefreshBar")
 ReAction.RegisterCallback(self, "OnDestroyBar")
 ReAction.RegisterCallback(self, "OnEraseBar")
 ReAction.RegisterCallback(self, "OnRenameBar")
 ReAction.RegisterCallback(self, "OnConfigModeChanged")
 end
-function module:PLAYER_AURAS_CHANGED()
+function module:OnEnable()
-self:UnregisterEvent("PLAYER_AURAS_CHANGED")
+self:UPDATE_SHAPESHIFT_FORMS() -- it doesn't fire on a /reloadui
--- on login the number of stances is 0 until this event fires during the init sequence.
+end
--- however if you just reload the UI the number of stances is correct immediately
--- and this event won't fire until you gain/lose buffs/debuffs, at which point you might
+function module:UPDATE_SHAPESHIFT_FORMS()
--- be in combat.
+-- Re-parse the rules table according to the new form list.
-if not InCombatLockdown() then
+-- This happens both at initial login (after PLAYER_ENTERING_WORLD)
-InitRules()
+-- as well as when gaining new abilities.
-for name, bar in ReAction:IterateBars() do
+InitRules()
-self:OnRefreshBar(nil,bar,name)
+for name, bar in ReAction:IterateBars() do
-end
+self:OnRefreshBar(nil,bar,name)
 end
 end
 function module:OnRefreshBar(event, bar, name)
 local c = self.db.profile.bars[name]

Mercurial > wow > reaction

comparison State.lua @ 97:5d3b7b025142